Update OSS-Fuzz Scripts to Use New QA-Assets Repo Structure#1913
Merged
Byron merged 1 commit intogitpython-developers:mainfrom May 8, 2024
Conversation
This change is required to support the changes to the seed data repo structure introduced in: gitpython-developers/qa-assets#2 This moves most of the seed data related build steps into the OSS-Fuzz Docker image build via `container-environment-bootstrap.sh`. This includes moveing the dictionaries into that repo. The fuzzing/README.md here should be updated in a follow-up with a link to the qa-assets repo (and probably some context setting about corpora in general) but I have opted to defer that as I think the functionality added by the seed data improvements is valuable as is and shouldn't be blocked by documentation writers block.
Byron
approved these changes
May 8, 2024
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for driving fuzzing forward, relentlessly!
I will set this to auto-merge so when done, you could merge the PR in qa-assets yourself.
Contributor
Author
Thanks for letting me! I've still got my eyes on
Thanks! Will do. |
Member
|
It turns out there is no auto-merging for me, so I will just merge both myself when I get back. |
DaveLak
deleted the
refactor-oss-fuzz-scripts-to-use-new-qa-assets-repo-layout
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merging gitpython-developers/qa-assets#2 should be coordinated with merging this PR.
This change is required to support the changes to the seed data repo structure introduced in:
gitpython-developers/qa-assets#2
This moves most of the seed data related build steps into the OSS-Fuzz Docker image build via
container-environment-bootstrap.sh. This includes moveing the dictionaries into that repo.The fuzzing/README.md here should be updated in a follow-up with a link to the qa-assets repo (and probably some context setting about corpora in general) but I have opted to defer that as I think the functionality added by the seed data improvements is valuable as is and shouldn't be blocked by documentation writers block.